fix: change the link for reactVirtualizedListProps to prop-types #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates a non-valid link to the prop-types of the react-sortiable-tree component.
wuweiweiwu
requested changes
Jun 8, 2018
| | dndType | string | String value used by [react-dnd](http://react-dnd.github.io/react-dnd/docs-overview.html) (see overview at the link) for dropTargets and dragSources types. If not set explicitly, a default value is applied by react-sortable-tree for you for its internal use. **NOTE:** Must be explicitly set and the same value used in order for correct functioning of external nodes | | ||
| | shouldCopyOnOutsideDrop | func or bool | Return true, or a callback returning true, and dropping nodes to react-dnd drop targets outside of the tree will not remove them from the tree. Defaults to `false`. <div>`({ node: object, prevPath: number[] or string[], prevTreeIndex: number, }): bool`</div> | | ||
| | reactVirtualizedListProps | object | Custom properties to hand to the [react-sortable-tree list](https://github.com/bvaughn/react-sortable-tree/blob/master/docs/List.md#prop-types) | | ||
| | reactVirtualizedListProps | object | Custom properties to hand to the [react-sortable-tree list](https://github.com/frontend-collective/react-sortable-tree/blob/master/src/react-sortable-tree.js#L757) | |
There was a problem hiding this comment.
hi, the correct link is actually https://github.com/bvaughn/react-virtualized/blob/master/docs/List.md#prop-types
I can merge it once it is updated.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a non-valid link to the prop-types of the react-sortiable-tree component.